Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update functional.py #992

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Update functional.py #992

merged 2 commits into from
Jan 28, 2024

Conversation

sxndqc
Copy link
Contributor

@sxndqc sxndqc commented Jan 27, 2024

Update type indicator

@Titus-von-Koeller Titus-von-Koeller merged commit 8ddfda1 into bitsandbytes-foundation:main Jan 28, 2024
@Titus-von-Koeller
Copy link
Collaborator

Good catch! Thanks for your contribution, really appreciated.

@akx
Copy link
Contributor

akx commented Jan 29, 2024 •
edited
Loading

This isn't a valid type annotation, though 😅

bitsandbytes/functional.py:893: error: Syntax error in type annotation  [syntax]
bitsandbytes/functional.py:893: note: Suggestion: Use Tuple[T1, ..., Tn] instead of (T1, ..., Tn)

(See #994)

@akx akx mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxndqc @Titus-von-Koeller @akx